diff --git a/CHANGELOG.md b/CHANGELOG.md index cf4191d25125c2ab55e729b17cd027d275de9743..47784ffa1d16e12323ef469129fce3e407f7bdca 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -49,6 +49,7 @@ v5.0.0 - Removed instance count from beginning of Array storage to improve memory alignment (!921) - Fix naming issue of duplicate Unit tests (!924) +- Fix warnings about missing virtual destructors in abstract classes (!932) **NekMesh**: - Add feature to read basic 2D geo files as CAD (!731) diff --git a/library/SolverUtils/Advection/Advection.h b/library/SolverUtils/Advection/Advection.h index 256733257f157676b92f6252626608d4f0ba7c0b..d330cee5da706d962b76b82794d5792d090217b4 100644 --- a/library/SolverUtils/Advection/Advection.h +++ b/library/SolverUtils/Advection/Advection.h @@ -69,6 +69,10 @@ typedef std::function pFields); diff --git a/library/SolverUtils/RiemannSolvers/RiemannSolver.h b/library/SolverUtils/RiemannSolvers/RiemannSolver.h index 1a0568f5da821b6ef8dd531a923f6a5665848b5c..0c7603a07f290e4907be8c120b68bb7e9396b753 100644 --- a/library/SolverUtils/RiemannSolvers/RiemannSolver.h +++ b/library/SolverUtils/RiemannSolvers/RiemannSolver.h @@ -160,6 +160,9 @@ namespace Nektar SOLVER_UTILS_EXPORT RiemannSolver( const LibUtilities::SessionReaderSharedPtr& pSession); + SOLVER_UTILS_EXPORT virtual ~RiemannSolver() + {}; + virtual void v_Solve( const int nDim, const Array > &Fwd,