Nektar merge requestshttps://gitlab.nektar.info/nektar/nektar/-/merge_requests2023-12-13T13:11:32Zhttps://gitlab.nektar.info/nektar/nektar/-/merge_requests/1705Fix to allow the specification of different number of iterations for differen...2023-12-13T13:11:32ZJacques XingFix to allow the specification of different number of iterations for different variable# Issue/feature addressed
In the `NekLinSysIter.cpp` class and subclasses, if `GlobalSysSolnInfo` is use to specify different parameters for different variable, only the parameters corresponding to the first variables blocks are used to ...# Issue/feature addressed
In the `NekLinSysIter.cpp` class and subclasses, if `GlobalSysSolnInfo` is use to specify different parameters for different variable, only the parameters corresponding to the first variables blocks are used to initialize the object in the constructor.
# Proposed solution
Pass as an argument parameter a string containing the variable name in the constructors of `NekLinSysIter.cpp` class and subclasses.
# Implementation
## Tests
The following test has been updated to test the possibility to use different maximum iteration number for different variables
`solvers/IncNavierStokesSolver/Tests/KovaFlow_m10_taylorHood_VCSImplicitLoc.xml`
# Suggested reviewers
*Please suggest any people who would be appropriate to review your code.*
# Notes
*Please add any other information that could be useful for reviewers.*
# Checklist
- [x] Functions and classes, or changes to them, are documented.
- ~~[ ] User guide/documentation is updated.~~
- [x] Changelog is updated.
- [x] Suitable tests added for new functionality.
- [x] Contributed code is correctly formatted. (See the [contributing guidelines](https://gitlab.nektar.info/nektar/nektar/-/blob/master/CONTRIBUTING.md#using-clang-format)).
- ~~[ ] License added to any new files.~~
- [x] No extraneous files have been added (e.g. compiler output or test data files).v5.5.0Dave MoxeyDave Moxeyhttps://gitlab.nektar.info/nektar/nektar/-/merge_requests/1385Draft: Disable use of SetRhsMagnitude for iterative static cond.2023-10-06T13:29:01ZChris CantwellDraft: Disable use of SetRhsMagnitude for iterative static cond.# Issue/feature addressed
When using IterativeStaticCond with a highly anisotropic elliptic solve, the iterative solver would no converge. This behaviour was inconsistent with other solvers (e.g. IterativeFull). The SetRhsMagnitude funct...# Issue/feature addressed
When using IterativeStaticCond with a highly anisotropic elliptic solve, the iterative solver would no converge. This behaviour was inconsistent with other solvers (e.g. IterativeFull). The SetRhsMagnitude function appears to be the culprit.
# Proposed solution
Disable SetRhsMagnitude for the IterativeStaticCond solver.
# Implementation
Currently just commented out.
## Tests
# Notes
None
# Checklist
- [X] Functions and classes, or changes to them, are documented.
- [X] User guide/documentation is updated.
- [ ] Changelog is updated.
- [ ] Suitable tests added for new functionality.
- [X] Contributed code is correctly formatted. (See the [contributing guidelines](https://gitlab.nektar.info/nektar/nektar/-/blob/master/CONTRIBUTING.md#using-clang-format)).
- [X] License added to any new files.
- [X] No extraneous files have been added (e.g. compiler output or test data files).
**Warning**
On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the `master` branch. To resolve these conflicts , see
https://gitlab.nektar.info/nektar/nektar/-/issues/295
Closes #123v5.5.0Chris CantwellChris Cantwell