Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 91
    • Issues 91
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 62
    • Merge requests 62
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1159

Fix GlobalLinSys generation for different variable coefficient entries

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dave Moxey requested to merge dmoxey/nektar:fix/varcoeff-hash into master Jun 26, 2020
  • Overview 42
  • Commits 33
  • Pipelines 12
  • Changes 57

This MR fixes the issue reported by @xfempty, in which two calls to HelmSolve with matrix keys that had different values of variable coefficients resulted in the same global system being used to perform the solve. This is achieved by changing the VarCoeffMap data structure, to allow for the efficient hashing of values in the coefficient map (and thus avoid computing a hash of the data every time HelmSolve is called).

Two additional issues are fixed:

  • a minor fix to the PETScFull solver, which had a small regression owing to !963 (merged);
  • fix for 3D element Helmholtz matrix construction, which did not pass matrix keys through to StdRegions correctly, meaning that variable-coefficient mass matrices did not work.
Edited Jul 11, 2022 by Dave Moxey
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/varcoeff-hash