Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 89
    • Issues 89
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1303

Fix diffusion IP implementation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Spencer Sherwin requested to merge fix/DiffusionIP into master Dec 30, 2021
  • Overview 25
  • Commits 49
  • Pipelines 31
  • Changes 46

Fix Diffusion IP to minic the stable implicit branch implementation. This required turning on some additonal terms and also fixing a call in LocTraceToTraceMap::AddTraceQuadToField to call as assmeble rather than scatter option to ensure all values are added to field rather than just the last trace entry.

Removed some const definition in the DoAdvection and DoDiffsuion of the compressible flow solver to make them compatible with defiition of the relevant factory pattern and avoid implicit deep copies arising.

Also updated the test files and started to update some descriptions in the diffusion and advection factory patterns to ensure they appear correctly in the summary list.

Finally also disabled a test hump3d_SEM_IP since it no longer executes but was not clear it was a valid test as running from a restart file created with LDGNS diffusion operator

Edited Dec 30, 2021 by Spencer Sherwin
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/DiffusionIP