Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1316

Draft: Fix PhysDeriv_SumFac_Hex

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Daniel Lindblad requested to merge dlindbla/nektar:fix/PhysDeriv_SumFac_Hex into master Mar 02, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

The previous implementation of the operator() in the class PhysDeriv_SumFac_Hex has a bug. The bug is located on line 1423, where the first index into the two dimensional array m_derivFac was set to [i*e+j]. This has now been corrected to [i*3+j].

It should be noted that the code may still run with this bug, but the results will of course not be 100% correct. If the code is compiled in debug mode, an error is raised by boost due to index out of bounds (the 2D array is a boost class).

A simple way to test whether the code produces correct results is to create a uniform flow through a cube with a few elements. If the physical derivative is wrong, then the vertical velocity (which should be identically 0), is in the order of 1E-13.

Edited Mar 02, 2022 by Daniel Lindblad
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/PhysDeriv_SumFac_Hex