Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 93
    • Issues 93
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 66
    • Merge requests 66
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1342

WIP: Fix file output for cell model history point filter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Chris Cantwell requested to merge ccantwel/nektar:fix/cardiac-cell-history-points into master May 18, 2022
  • Overview 0
  • Commits 1
  • Changes 4

Issue/feature addressed

In the CardiacEPSolver, the CellModelHistoryPoint filter did not correctly write out data to file. This was because of changes which had been implemented in the base class HistoryPoint filter.

Proposed solution

Update the CellModelHistoryPoint filter to have its own code for writing out to file.

Implementation

The v_WriteData function was overridden in the class to provide a working implementation and called from the v_Update function when data needs to be written to file.

Tests

Notes

None

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Newly added files are correctly formatted.
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/cardiac-cell-history-points