Skip to content

Switch from SIP to IIP method

João Isler requested to merge fix/DiffusionIP into master

Issue/feature addressed

  • We observed that high frequency oscillations are created in the third direction when the symmetric term of the interior penalty method is used (symmetry interior penalty method). These high frequency oscillations were observed in a two-dimensional geometry which was extruded in the z-direction.

Proposed solution

  • In this merge request, we changed the flag that defines the type of the interior penalty method. So, instead of using the symmetric interior penalty, we define the incomplete interior penalty method as the default for the IP method. The incomplete interior penalty method does not use the symmetry term for the spatial discretisation.

Implementation

  • The only change was made in the DiffusionIP.cpp file, where we changed the flag which defines the type for the IP method.

Tests

  • A small test case was already created in order to debug this issue. In a near future, a new branch will be created to properly debug this issue.

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Edited by Spencer Sherwin

Merge request reports