Skip to content

Draft: Fix missing execution conditions for dockerhub-deploy jobs.

Chris Cantwell requested to merge ccantwel/nektar:fix/ci-dockerhub-deploy-exec-conditions into master

Issue/feature addressed

The Gitlab CI configuration prevents jobs being created for commits when no code files are changed, such as when only the VERSION or CHANGELOG are edited. However, the dockerhub-deploy jobs were missing these conditions resulting in the system attempting to create the jobs, but failing due to earlier dependencies not having been created.

Proposed solution

Apply execution conditions also to the dockerhub-deploy jobs.

Implementation

Update dockerhub-deploy-template to include the execution conditions common to all other jobs.

Tests

N/A

Notes

None

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Merge request reports