Skip to content

fix-functional approach for accessing m_phys and m_coeff

Mohsen Lahooti requested to merge redesign/storage-expListData2 into master

Issue/feature addressed

Many parts of the code access m_phys and m_coeff as a member function (and usually via the use of ExpList). This MR, replaces those access with the functional approach where m_phys and m_coeffs would be passed as a function argument. This will restore a more consistent approach and would be an interim step for the new storage design.

Proposed solution

Those incident has spotted and the functions that directly accessed those member data are modified to have them as argument

Tests

Existing test check modifications

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [NA] User guide/documentation is updated.
  • Changelog is updated.
  • [NA] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [NA] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Edited by Spencer Sherwin

Merge request reports