Skip to content

Removed all std::unary_function classes

Mashy Green requested to merge fix/remove-unary_function into master

Issue/feature addressed

std::unary_functions are deprecated from C++-11 and removed in C++-17 (see https://en.cppreference.com/w/cpp/utility/functional/unary_function). In our current minimum requirements of C++-14 the compiler ignores this base class, but as we intend to move to C++-17 having them will create errors. On newer versions of clang and gcc they already throw warnings when using C++-14.

Proposed solution

Remove all the std::unaray_function decelerations from the code.

Implementation

See above.

Tests

No new tests required.

Notes

Validated with local ctest that removing the declerations has not broken anything (as expected).

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Edited by Mashy Green

Merge request reports