Skip to content

Fix a shadowed loop counter variable in CardiacEP benchmark filter.

Jacques Xing requested to merge CFD-Xing/nektar:fix/CardiacEPSolver-v_Finalise-error into master

Issue/feature addressed

I noticed a potential typo in the v_Finalise function of solvers/CardiacEPSolver/Filters/FilterBenchmark.cpp

Proposed solution

The propose solution is to fix the indexing of the outer for loop.

Checklist

  • [ ] Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • [ ] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Edited by Chris Cantwell

Merge request reports