Skip to content

Fix some Woverloaded-virtual warning in CardiacEPSolver

Issue/feature addressed

The base class for the definition of the virtual function v_InitObject has been changed. As a result the derived functions defined in CardiacEPSolver are probably never called...

Proposed solution

Modify the derived class definition of the virtual function v_InitObject to ensure consistency. The override key word is also added to avoid future issues.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • [ ] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Edited by Jacques Xing

Merge request reports