Fixed Taylor-Hood expansions for Velocity-Correction Scheme with weak pressure forcing
Issue/feature addressed
The Velocity Correction scheme with weak pressure forcing (VCSWeakPressure) did previously call the inner product operator IProductWRTDerivBase via m_fields[0] which would use the velocity expansion. However, the taylor-hood expansion uses different polynomial orders for velocity and pressure expansion leading to a wrong forcing term.
Proposed solution
Call IProductWRTDerivBase via the pressure ExpList (m_pressure)
Implementation
Simply changed "m_fields[0]->" to "m_pressure->"
Tests
Added regression tests based on Kovasznay flow that runs IncNavierStokesSolver with VSCWeakPressure and a Taylor-Hood expansion.
Notes
None
Checklist
-
Functions and classes, or changes to them, are documented. -
User guide/documentation is updated. -
Changelog is updated. -
Suitable tests added for new functionality. -
Contributed code is correctly formatted. (See the contributing guidelines). -
License added to any new files. -
No extraneous files have been added (e.g. compiler output or test data files).
Warning
On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see
#295 (closed)