Chi Hin Chan requested to merge fix-fieldconvert-addfld into master Nov 30, 2022

Issue/feature addressed

Using FieldConvert -m addfld:fromfld::scale=-1 <.xml> returns a segmentation fault. This format is based on the current syntax in the user-guide.

Proposed solution

A tag for the xml file i.e ":fromxml=" should be included for the addfld module to be working correctly.

Implementation

FieldConvert -m addfld:fromfld::scale=-1:fromxml=<.xml> works. Corrected user-guide.

Tests

Tested on v5.3.0

Notes

Checklist

Functions and classes, or changes to them, are documented.
User guide/documentation is updated.
Changelog is updated.
Suitable tests added for new functionality.
Contributed code is correctly formatted. (See the contributing guidelines).
License added to any new files.
No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Edited Dec 14, 2022 by Chi Hin Chan

Updated correct syntax for FieldConvert -m addflds