Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1459

Add missing override keyword to virtual functions in LibUtilities

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jacques Xing requested to merge CFD-Xing/nektar:feature/override-libutilities into master Dec 02, 2022
  • Overview 1
  • Commits 15
  • Pipelines 7
  • Changes 81

Issue/feature addressed

Many virtual functions in derived class of the LibUtilities directory do not have the override keyword. This make the code unsafe if someone changes the definition of the base class.

Proposed solution

Add the override keyword to the relevant functions in the LibUtilities directory. The virtual keyword is also explicitly added to all virtual functions.

Tests

Suggested reviewers

Please suggest any people who would be appropriate to review your code.

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • [ ] Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • [ ] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited Dec 05, 2022 by Jacques Xing
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/override-libutilities