Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1469

Make virtual functions protected consistently

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jacques Xing requested to merge CFD-Xing/nektar:feature/protected-virtual into master Dec 27, 2022
  • Overview 7
  • Commits 38
  • Pipelines 7
  • Changes 41

Issue/feature addressed

Derived classes are frequently accessed through a base class pointer in the code. The template pattern provides a public API through the base class and provides virtual functions which can be overloaded in derived classes to specialise functionality. These virtual functions should not be publicly accessible themselves, but may need to be used explicitly by further derived classes in order to extend functionality and minimise code duplication. As such they should be made protected, rather than public or private.

Tests

Suggested reviewers

@ccantwel

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • [ ] Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • [ ] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited Dec 29, 2022 by Chris Cantwell
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/protected-virtual