Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1473

Draft: Fixing Field Forcing for the Homogenous case

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Stanislaw Gepner requested to merge fix/FieldForcingNotWorkingInHomogenousCase into master Jan 12, 2023
  • Overview 5
  • Commits 5
  • Changes 2

Issue/feature addressed

When using BodyForce based on the additional field in the homogenous case forcing is applied only to the mean mode (0 plane)

Proposed solution

Modify the portion of the code in BodyForcing responsible for this adding a call to the HomogenousFwdTransform

Implementation

Implementation is not perfect. It requires a copy of the local solution vector to be made and processed.

Tests

Suggested reviewers

Dave Moxey as he is to blame for the original implementation.

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/FieldForcingNotWorkingInHomogenousCase