Skip to content

Fixed Hdf5 IO Issue

Mohsen Lahooti requested to merge mlahooti/nektar:fix/hdf5-unableToOpen into master

Issue/feature addressed

fixed the IO problem with Hdf5 where the code was not able to open output file. This is in connection with the issue #325 (closed)

Proposed solution

  1. There were several missing GetSpaceComm() communicator in the IO class for Hdf5 in LibUtilities/BasicUtils which is fixed
  2. The parallel in time root was set to open the file which is now restored to root to open the file
  3. Similar fix for missing GetSpaceComm() is done for XML and Point output classes in LibUtilities/BasicUtils

Implementation

Tests

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • [ ] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Edited by Mohsen Lahooti

Merge request reports