Skip to content

Remove unnecessary for loop in NekLinSysIterGMRES

Jacques Xing requested to merge CFD-Xing/nektar:fix/remove-unecessary-for-loop-in-neklinsysitergmres into master

Issue/feature addressed

There is a function call to Set_Rhs_Magnitude embedded in a for loop in NekLinSysIterGMRES.cpp. However, as the variable m_rhs_magnitude is set to 1.0 afterward, the function call and the for loop are not necessary. This problem was previously reported in issue #300 (closed).

Proposed solution

Remove unnecessary for loop.

Implementation

Tests

Suggested reviewers

Please suggest any people who would be appropriate to review your code.

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • [ ] Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • [ ] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing

Merge request reports