Skip to content

Fix for variable P Tets

Spencer Sherwin requested to merge fix/TetVariableP into master

Issue/feature addressed

Variable P on tetrahedral were causing problems within the redesign code comparison and previously were observed to give strange answers when introducing a variable P spatial definition by Jaoa. The standard Tet was making an incorrect assumption about the layout of the modes and even the examples in the code documentation had to many modes. There GetBoundaryMap was not returning the correct values as well as the GetTraceInteriorToElementMap()

Proposed solution

Put in the correct ordering and numbering for these routines

Implementation

See StdTetExp.cpp in MR

Tests

This is now passing in the Redesign code. Will ask Joao to test his previous work to identify an appropriate test.

Suggested reviewers

Joao, Dave

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing

Merge request reports

Loading