Skip to content

Fix/pulsewave filters

Ted Stokes requested to merge TedStokes/nektar:fix/pulsewaveFilters into master

Issue/feature addressed

Various filters not working for the PulseWaveSolver, closes #152 (closed)

Proposed solution

Filters used in PulseWaveSolver need a DOMAIN attribute specified in the session file.

Implementation

Filters fields are set up with SetToOneSpaceDimension false so that points (ie FilterHistoryPoints) can be evaluated at their real coordinates.

Tests

Have modified one test to output history points as a naive check/test

Suggested reviewers

@ssherw

Notes

Checklist

  • [ ] Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Spencer Sherwin

Merge request reports

Loading