Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 93
    • Issues 93
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 59
    • Merge requests 59
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !758

Fix/rm_getoffsetelmtid

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Spencer Sherwin requested to merge fix/GetOffsetElmtId into master Mar 27, 2017
  • Overview 13
  • Commits 13
  • Changes 39

Remove the GetOffset_Elmt_Id and associated m_offset_elmt_id which was only being used in 2D and lead to errors when Quads were listed before Tris. Removing this option fixes the known errors in Dealiasing (actually the ExpList::PhysInterp1DScaled and PhysGalerinProjection1DScaled) . There was also an issue with GetBndExp which assumed every element was consecutive and it was not causing issues in pressure boundary conditions in the IncNavierStokesSolver.

The removal meant two tests needed to be tuned possibly due to the fact that they had boundaries that contained tris and quads.

I have also had to turn off one test in FieldConvert (outflow_pointtofld) since the outflow.pts file is now in the wrong order.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/GetOffsetElmtId