Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
Nektar
Nektar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 84
    • Issues 84
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 44
    • Merge Requests 44
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Nektar
  • NektarNektar
  • Merge Requests
  • !883

Merged
Opened Dec 01, 2017 by Michael Turner@mt4313Maintainer

feature/tp-triangle

  • Overview 4
  • Commits 4
  • Changes 13

This MR reverts previous work to pull triangle into Nektar++ and modify the source to better suit us. It proved that all the planned work on triangle never happened and the small amount that did may have reduced its robustness. For the sake of maintainability, this reverts triangle to being a thirdparty library taken directly from the unmodified source.

In addition a number of other issues have been found.

  • Part of the high-order optimisation code was commented out (probably from debugging)
  • Small optimisation to the octree code
  • Fix progress bar in octree code for 2D meshes
  • tAtArcLength function was not accurately calculated, this caused issues in very fine meshes
Edited Dec 08, 2017 by Julian Marcon
Assignee
Assign to
Reviewer
Request review from
v5.0.0
Milestone
v5.0.0 (Past due)
Assign milestone
Time tracking
Reference: nektar/nektar!883
Source branch: feature/tp-triangle

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.