Merge branch 'fix/FileFunctionReading' into 'master'
Fix: Dont read the same files again for every variable This branch adds a check to prevent EquationSystem from reading the same fld/pts files again for each variable. This gives a huge speedup in some cases. I also split the EquationSystem::EvaluateFunction method into three new methods: one for expressions, one for fld files and one for pts files to make the code more readable. However, i think its still a mess with lots of duplicate code and even more things that would make much more sense in some other class. Even worse is that the Forcing base class holds a complete copy of this code. I would like to move the whole Function logic from Forcing and EquationSystem into a new class that lives in SolverUtils in the future. Should we discuss that here or do you want me to write to the mailing list? See merge request !670
No related branches found
No related tags found
Showing
- CHANGELOG.md 1 addition, 0 deletionsCHANGELOG.md
- library/SolverUtils/EquationSystem.cpp 331 additions, 175 deletionslibrary/SolverUtils/EquationSystem.cpp
- library/SolverUtils/EquationSystem.h 37 additions, 2 deletionslibrary/SolverUtils/EquationSystem.h
- solvers/APESolver/Tests/APE_2DPulseInterp_WeakDG_MODIFIED.xml 1 addition, 2 deletions...ers/APESolver/Tests/APE_2DPulseInterp_WeakDG_MODIFIED.xml
- solvers/APESolver/Tests/APE_2DPulseInterp_baseflow_0.00000000E+00.pts 26 additions, 26 deletions...olver/Tests/APE_2DPulseInterp_baseflow_0.00000000E+00.pts
- solvers/APESolver/Tests/APE_2DPulseInterp_baseflow_1.00000000E-05.pts 26 additions, 26 deletions...olver/Tests/APE_2DPulseInterp_baseflow_1.00000000E-05.pts
- solvers/APESolver/Tests/APE_2DPulseInterp_baseflow_2.00000000E-05.pts 26 additions, 26 deletions...olver/Tests/APE_2DPulseInterp_baseflow_2.00000000E-05.pts
Loading
Please register or sign in to comment