Skip to content
Snippets Groups Projects
Commit df13e623 authored by Chris Cantwell's avatar Chris Cantwell
Browse files

Merge branch 'fix/zlib-install-mac' into 'master'

Fix/zlib install mac

This MR fixes install paths for OS X when compiling zlib from third party sources. It also removes now unneeded linker flags since CMake handles library dependencies properly.

See merge request !484
parents be18be15 32296c9e
No related branches found
No related tags found
No related merge requests found
......@@ -107,11 +107,7 @@ ENDIF( NEKTAR_USE_VTK )
INCLUDE(${NEKTAR++_LIBRARY_DIRS}/cmake/Nektar++Libraries.cmake)
# platform dependent options
if(${CMAKE_SYSTEM} MATCHES "Linux.*")
IF(${CMAKE_SYSTEM} MATCHES "Linux.*")
set(NEKTAR++_TP_LIBRARIES ${NEKTAR++_TP_LIBRARIES} rt)
SET(NEKTAR++_DEFINITIONS "${NEKTAR++_DEFINITIONS} -pthread")
endif(${CMAKE_SYSTEM} MATCHES "Linux.*")
if(${CMAKE_SYSTEM} MATCHES "Darwin-*")
SET(NEKTAR++_DEFINITIONS "${NEKTAR++_DEFINITIONS} -Wl,-undefined,dynamic_lookup -Wl,-rpath,${CMAKE_INSTALL_PREFIX}/${LIB_DIR} -Wl,-rpath,${Boost_LIBRARY_DIRS}")
endif(${CMAKE_SYSTEM} MATCHES "Darwin-*")
ENDIF(${CMAKE_SYSTEM} MATCHES "Linux.*")
......@@ -123,11 +123,6 @@ MACRO(ADD_NEKTAR_EXECUTABLE name component sources)
ENDIF( ${CMAKE_SYSTEM} MATCHES "Linux.*" )
IF( ${CMAKE_SYSTEM} MATCHES "Darwin-*")
SET_TARGET_PROPERTIES(${name}
PROPERTIES LINK_FLAGS "-Wl,-undefined,dynamic_lookup -Wl,-rpath,${CMAKE_INSTALL_PREFIX}/${LIB_DIR} -Wl,-rpath,${Boost_LIBRARY_DIRS}")
ENDIF( ${CMAKE_SYSTEM} MATCHES "Darwin-*")
SET_PROPERTY(TARGET ${name} PROPERTY FOLDER ${component})
INSTALL(TARGETS ${name}
RUNTIME DESTINATION ${NEKTAR_BIN_DIR} COMPONENT ${component} OPTIONAL
......
......@@ -55,6 +55,12 @@ IF (THIRDPARTY_BUILD_ZLIB)
${TPSRC}/zlib-1.2.7
)
IF (APPLE)
EXTERNALPROJECT_ADD_STEP(zlib-1.2.7 patch-install-path
COMMAND ${CMAKE_INSTALL_NAME_TOOL} -id ${CMAKE_INSTALL_PREFIX}/${NEKTAR_LIB_DIR}/libz.1.2.7.dylib ${TPDIST}/lib/libz.1.2.7.dylib
DEPENDEES install)
ENDIF ()
IF (WIN32)
SET(ZLIB_LIBRARY zlib CACHE FILEPATH
"Zlib library" FORCE)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment