Skip to content
Snippets Groups Projects

Fix/ldg penalty

Merged Giacomo Castiglioni requested to merge castigli/nektar:fix/LDG-penalty into master

Adding penalty term to LDGNS and switching on the LDG penalty term. The coefficient for LDG penalty term is simply set to 1, it should be reviewed later on. The coefficient for LDGNS is proportional to viscosity/thermal conductivity and inversely proportional to element size. The LDG has been lightly restructured to allow for a general flux. This allows for a diffusion coefficient different than 1 for UnsteadyDiffusion, UnsteadyAdvectionDiffusion and ViscousBurger, for the AV flux computation to be moved in the AV class, and eventually to merge LDG and LDGNS together.

  • cleanup LDGNS "upwinding"
  • cleanup LDG "upwinding"
  • move AV flux computation
  • convergence study LDG
  • convergence study LDGNS
  • check shock capturing
  • update tests
  • update documentation
Edited by Giacomo Castiglioni

Merge request reports

Pipeline #1167 passed

Pipeline passed for 6b3cfb4f on castigli:fix/LDG-penalty

Merged by Dave MoxeyDave Moxey 5 years ago (Nov 7, 2019 9:27am UTC)

Merge details

  • Changes merged into with 7598e614.
  • Deleted the source branch.

Pipeline #1181 failed

Pipeline failed for 7598e614 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading