Added Integral method to ExpListHomogeneous1D class
Fix erroneous behaviour of FieldConvert mean module in 3DH1D cases where the integral was not scaled by the number of planes. Virtual Integral method is added to the ExpListHomogeneous1D class. To do:
-
Fix ProcessMean -
Fix ProcessInnerProduct
Merge request reports
Activity
added fieldconvert label
assigned to @a_cassinelli and @ssherw
@ssherw I believe the only place where Integral was called on a 3DH1D exp list (beyond the ProcessMean routine) is the SPM aero forces filter we recently introduced - which potentially means there is also a bug there, since there is currently no test for that feature as Andres did not have a chance to complete that. I have added this point to the issue related to necessary developments for the SPM feature.
mentioned in issue #221
Resolved by Andrea CassinelliIn some other places, the correctness of result is base on the fact that 3DH1 doesn't multiplies dz. So, I am afraid this commit may affect other codes.
- Last reply by Andrea Cassinelli
added 1 commit
- 940ada55 - Moved specialised Integral for Homogeneous1D and fixed InnerProduct module
added 71 commits
-
940ada55...f6a50853 - 70 commits from branch
master - ac2cfb20 - Merge branch 'master' into fix/mean_3DH1D
-
940ada55...f6a50853 - 70 commits from branch
@ssherw @dmoxey This branch now runs the mean and innerproduct modules correctly. I thought to keep things tidy I will remove PhysIntegral in a separate branch. When you have a chance to have a look let me know if you have any comments, otherwise I think it can be merged.
Edited by Andrea Cassinelliadded 1 commit
- 57bd7205 - Added MultiRegions demo and test for 3DH1D integral
