Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 91
    • Issues 91
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 65
    • Merge requests 65
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1242

WIP: Resolve segfault when missing TimeIntegrationMethod for unsteady problem - Fixes #260

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Jeremy Cohen requested to merge jhc02/nektar:fix/issue260 into master Apr 15, 2021
  • Overview 1
  • Commits 4
  • Pipelines 1
  • Changes 263+

This MR adds an assertion to ensure that the code fails cleanly with a helpful error message when the TimeIntegrationMethod is not specified in the <SOLVERINFO> section of the input file for an unsteady problem.

Since the if statement that previously wrapped the block of code undertaking the time integration initialisation has been removed, additional comments have been added to mark the start and end of this code block. This is intended to aid understanding and future maintainability of this section of code.

This resolves issue #260

Edited Apr 16, 2021 by Jeremy Cohen
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/issue260