Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 73
    • Merge requests 73
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1242

WIP: Resolve segfault when missing TimeIntegrationMethod for unsteady problem - Fixes #260

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Jeremy Cohen requested to merge jhc02/nektar:fix/issue260 into master Apr 15, 2021
  • Overview 1
  • Commits 4
  • Pipelines 1
  • Changes 263+

This MR adds an assertion to ensure that the code fails cleanly with a helpful error message when the TimeIntegrationMethod is not specified in the <SOLVERINFO> section of the input file for an unsteady problem.

Since the if statement that previously wrapped the block of code undertaking the time integration initialisation has been removed, additional comments have been added to mark the start and end of this code block. This is intended to aid understanding and future maintainability of this section of code.

This resolves issue #260 (closed)

Edited Apr 16, 2021 by Jeremy Cohen
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/issue260