Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 89
    • Issues 89
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 75
    • Merge requests 75
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1348

Fix issue with NekMesh Python logger

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Dave Moxey requested to merge fix/nekmesh-python-logger into master Jun 29, 2022
  • Overview 0
  • Commits 3
  • Pipelines 1
  • Changes 3

Issue/feature addressed

This MR fixes a small sequencing issue with the NekMesh Python API. When modules are created, if an unknown key is used in the initialisation of the module then a segmentation fault is raised because the output uses an uninitialised logger reference, e.g.

from NekPy.NekMesh import Mesh, InputModule
mesh = Mesh()
module = InputModule("xml", mesh, "input.xml", unknownconfig = False)
module.Process() # this line will segfault

Proposed solution

Re-order the parsing of configuration options so that the logger is constructed before any other options are set.

Implementation

See above.

Tests

One small test has been added as a unit test.

Notes

N/A

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Newly added files are correctly formatted.
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited Jun 30, 2022 by Dave Moxey
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/nekmesh-python-logger