Skip to content

Draft: Disable use of SetRhsMagnitude for iterative static cond.

Chris Cantwell requested to merge neptune/nektar-preconditioners:fix/disable-rhs-mag-staticcond into master

Issue/feature addressed

When using IterativeStaticCond with a highly anisotropic elliptic solve, the iterative solver would no converge. This behaviour was inconsistent with other solvers (e.g. IterativeFull). The SetRhsMagnitude function appears to be the culprit.

Proposed solution

Disable SetRhsMagnitude for the IterativeStaticCond solver.

Implementation

Currently just commented out.

Tests

Notes

None

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Closes #123 (closed)

Merge request reports