Dave Moxey requested to merge feature/disable-default-warnings into master Nov 18, 2022

Issue/feature addressed

This MR changes the default value of NEKTAR_ERROR_ON_WARNINGS to OFF. As discussed in #311 (closed) this is a hindrance to local development, and in any case is now detected via linting in CI.

Proposed solution

Set default value of NEKTAR_ERROR_ON_WARNINGS to OFF.

Implementation

N/A

Tests

N/A: detected by CI.

Notes

Fixes #311 (closed).

Checklist

Changelog is updated.

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

Disable -Werror by default