Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 93
    • Issues 93
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 66
    • Merge requests 66
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1443

Disable -Werror by default

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dave Moxey requested to merge feature/disable-default-warnings into master Nov 18, 2022
  • Overview 1
  • Commits 2
  • Pipelines 1
  • Changes 2

Issue/feature addressed

This MR changes the default value of NEKTAR_ERROR_ON_WARNINGS to OFF. As discussed in #311 (closed) this is a hindrance to local development, and in any case is now detected via linting in CI.

Proposed solution

Set default value of NEKTAR_ERROR_ON_WARNINGS to OFF.

Implementation

N/A

Tests

N/A: detected by CI.

Notes

Fixes #311 (closed).

Checklist

  • Changelog is updated.

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: feature/disable-default-warnings