Update solvers' CMakeLists.txt to fix some warnings detection issue

Issue/feature addressed

The current implementation of NektarCommon.cmake does not properly set compiler flags for files in the solvers/ directory. This results in many undetected warnings/errors in the CI.

Proposed solution

The proposed solution is to use modify the solvers' CMakeLists.txt file.

Implementation

A SET_COMMON_PROPERTIES(${name}-obj) is added in the solvers' CMakeLists.txt file.

Checklist

• [ ] Functions and classes, or changes to them, are documented.
• [ ] User guide/documentation is updated.
• Changelog is updated.
• [ ] Suitable tests added for new functionality.
• Contributed code is correctly formatted. (See the contributing guidelines).
• [ ] License added to any new files.
• No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295 (closed)

changed milestone to %v5.3.0

added 1 commit

• ec22d55e - Update CHANGELOG.md

Compare with previous version

marked this merge request as ready

changed the description

marked the checklist item Changelog is updated. as completed

marked the checklist item Contributed code is correctly formatted. (See the contributing guidelines). as completed

marked the checklist item No extraneous files have been added (e.g. compiler output or test data files). as completed

marked this merge request as draft

marked the checklist item Contributed code is correctly formatted. (See the contributing guidelines). as incomplete

@CFD-Xing The MR description is rather brief. Please could you update it, in line with the template, to elaborate on the exact issue addressed and how this addresses it?

added 1 commit

• 3e9416a9 - Update root CMakeLists.txt and NektarCommon.cmake to fix some

Compare with previous version

marked this merge request as ready

changed the description

added build system label

requested review from @dmoxey

assigned to @ccantwel

mentioned in merge request !1438 (merged)

added 1 commit

• 45a00bff - Fix some formatting issue

Compare with previous version

changed the description

resolved all threads

!1438 (merged) also has to be merged first, but for some reason I can't added it as a dependency.

resolved all threads

changed title from Update NektarCommon.cmake to fix some warnings detection issue to Update root CMakeLists.txt and NektarCommon.cmake to fix some warnings detection issue

Additional warnings are now detected on the CI but seems to cause some additional issues (that I do not fully understand) on the build-and-test CI. @ccantwel @dmoxey. I am also open to alternate implementation to fix to warning detection issues if someone had better suggestions.

added 1 commit

• 9b19b10b - Revert root CMakeList.txt and NektarCommon.cmake and update solvers's

Compare with previous version

added 1 commit

• f209dce2 - Revert NektarCommon.cmake

Compare with previous version

added 1 commit

• 6f870063 - Update CHANGELOG.md

Compare with previous version

changed title from Update root CMakeLists.txt and NektarCommon.cmake to fix some warnings detection issue to Update solvers' CMakeLists.txt to fix some warnings detection issue

changed the description

added 15 commits

• 6f870063...9cb7464a - 14 commits from branch nektar:master
• 2864f5b7 - Merge branch 'master' of https://gitlab.nektar.info/nektar/nektar into fix/NektarCommon.cmake

Compare with previous version

added 3 commits

• 2864f5b7...e9a9e0da - 2 commits from branch nektar:master
• b79dbc25 - Merge branch 'master' of https://gitlab.nektar.info/nektar/nektar into fix/NektarCommon.cmake

Compare with previous version

resolved all threads

marked the checklist item Contributed code is correctly formatted. (See the contributing guidelines). as completed

resolved all threads

resolved all threads

merged

mentioned in commit a854f656