Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1485

Fix TimeIntegrationDemo.cpp and add ESDIRK tst files to the CI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jacques Xing requested to merge CFD-Xing/nektar:fix/timeintegrationdemo into master Jan 29, 2023
  • Overview 36
  • Commits 39
  • Pipelines 17
  • Changes 36

Issue/feature addressed

The TimeIntegrationDemo.cpp was apparently originally designed to solve the advection-diffusion problem by an explicit discretization of the advection term and a implicit discretization of the diffusion term. Using the Demo for the validation of pure explicit scheme is not adequate. Also, the original code is not suitable for ESDIRK schemes.

Proposed solution

A few flags have been added to the code to properly deal with the various time-integration schemes.

Tests

Suggested reviewers

Please suggest any people who would be appropriate to review your code.

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • [ ] No extraneous files have been added (e.g. compiler output or test data files).
Edited Jan 29, 2023 by Jacques Xing
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/timeintegrationdemo