Feature/nekfactory remove unused function

Issue/feature addressed

There is a unused function GetKey in NekFactory. The purpose of this function is to return the factory key from a given description. This seems unsafe as several keys might be associated with an empty description or a non-unique description.

Proposed solution

Remove unused function GetKey from NekFactory

Implementation

Tests

Suggested reviewers

Please suggest any people who would be appropriate to review your code.

Notes

Please add any other information that could be useful for reviewers.

Checklist

• [ ] Functions and classes, or changes to them, are documented.
• [ ] User guide/documentation is updated.
• Changelog is updated.
• [ ] Suitable tests added for new functionality.
• Contributed code is correctly formatted. (See the contributing guidelines).
• [ ] License added to any new files.
• No extraneous files have been added (e.g. compiler output or test data files).

library/LibUtilities/BasicUtils/NekFactory.hpp

@@ -138,7 +138,7 @@ public:
      * Searches the factory's map for the given key and returns a shared
      * base class pointer to a new instance of the associated class.
      * @param   idKey           Key of class to create.
-     * @param   x               Parameter to pass to class constructor.
+     * @param   args            Parameter to pass to class constructor.
      * @returns                 Base class pointer to new instance.
      */
     tBaseSharedPtr CreateInstance(tKey idKey, tParam... args)
@@ -251,26 +251,6 @@ public:
         }
     }
 
-    /**
-     * @brief Retrieves a key, given a description
-     */
-    tKey GetKey(std::string pDesc)
-    {
-#ifdef NEKTAR_USE_THREAD_SAFETY
-        ReadLock vReadLock(m_mutex);
-#endif
-
-        for (auto &it : *getMapFactory())
-        {
-            if (it.second.m_desc == pDesc)
-            {
-                return it.first;
-            }
-        }
-        std::string errstr = "Module '" + pDesc + "' is not known.";
-        ASSERTL0(false, errstr);
-    }
-
     /**
      * @brief Returns the description of a class
      */
@@ -300,8 +280,8 @@ protected:
     }
 
 private:
-    NekFactory(const NekFactory &rhs);
-    NekFactory &operator=(const NekFactory &rhs);
+    NekFactory(const NekFactory &rhs) = delete;
+    NekFactory &operator=(const NekFactory &rhs) = delete;
 
     TMapFactory mMapFactory;