Skip to content

feature/L-SIAC-ARS

Allen Sanderson requested to merge ARSanderson/nektar:feature/L-SIAC-ARS into master

Issue/feature addressed

Merge of the LSIAC branch with Allen's cleanup.

Implementation

This MR supersedes !1107 (closed)

Tests

Note: the tests have been re-baselined. However they are not consistent with a merge with master or across architectures / OS.

Suggested reviewers

Mohsen

Notes

The main difference between this MR and MR1107 is pedantic cleanup of the code so to meet the Nektar++ coding standards.

Missing are the comments need by the original authors on specific code functionality.

The code has not been clang-formatted as that is not yet set up on my workstation.

I have been having a difficult time with the Scotch library being found correctly on OS X (Linux was okay). Namely the search for ptscotch include and libs is problematic. I finally created soft links to overcome the issue.

There is some remaining cleanup to be done:

Checklist

  • [NA] Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Merge request reports