Skip to content

added external flag for msvc

James Edgeley requested to merge (removed):fix/msvccompilerflags into master

Issue/feature addressed

-isystem is not a valid flag for MSVC. /external:I is the equivalent:

Proposed solution

if statement in CMakelists.txt to check if compiler is MSVC



Suggested reviewers

Please suggest any people who would be appropriate to review your code.


Please add any other information that could be useful for reviewers.


  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by James Edgeley

Merge request reports