Skip to content

Fix NonLinearPeregrine Solver

Jacques Xing requested to merge CFD-Xing/nektar:fix/nonlinearperegrine_solver into master

Issue/feature addressed

Due to a change of API, the NonlinearPeregrine is not working anymore. This MR address this issue.

Proposed solution

The NonlinearPeregrine uses a deprecated version of AddTraceIntegral. This MR update the NonlinearPeregrine to use the updated version of AddTraceIntegral.

The ShallowWaterSolver.cpp main file has also been update to use the driver class. Previous test results have to be changed because L2error norms were previously normalized (The Standard driver does not normalized the L2 error norm).

Implementation

Tests

NonlinearSWE_Peregrine_SolitaryWave_DG_P6.xml

Suggested reviewers

Please suggest any people who would be appropriate to review your code.

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing

Merge request reports