Skip to content

Tidy MatrixFreeOps physderiv and helmholtz

BOYANG XIA requested to merge xby2233/nektar:tidy_matfree into master

Issue/feature addressed

Tidy MatrixFreeOps physderiv and helmholtz. Prepare for future development.

Proposed solution

Implementation

  • Extract PhysDerivTensorXDKernel() out of PhysDerivXDKernel(). To do the PhysDeriv operation, call PhysDerivTensorXDKernel() and PhysDerivXDKernel sequentially. After this change, it's possible to integrate PhysDeriv and Helmholtz in the same operator by just calling PhysDerivTensorXDKernel once.
  • Remove the unused argument bwd in the Helmholtz2DKernel/DiffusionCoeff2DKernel. Only deriv0 and deriv1 will actually be used.

Tests

No additional tests are required.

Suggested reviewers

@dmoxey @CFD-Xing

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • [ ] Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Merge request reports