Skip to content

Update configuration for Visual Studio toolchain

Chris Cantwell requested to merge ccantwel/nektar:ci/update-windows-build into master

Issue/feature addressed

The Windows CI toolchain was very outdated. The runners have now been updated to Visual Studio 2022, CMake 3.27.7, Git 2.37 with Boost 1.82. As a consequence, the CI configuration needs updating to reflect changes in the toolchain name and CMake command-line interface.

Proposed solution

Update CI configuration appropriately.

Implementation

The following changes were needed:

  • Remove the specific toolchain. CMake should find the installed toolchain.
  • Change the removed --config Debug CMake command-line option to the more regular -DCMAKE_BUILD_TYPE=Debug option, consistent with Linux.

Tests

No extra tests required.

Suggested reviewers

@dmoxey @CFD-Xing

Notes

All pipeline will fail the windows runners until these changes are merged in. In particular we will need to rebase-on/merge-in master after this merge in order for Windows jobs to run correctly.

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Chris Cantwell

Merge request reports