Skip to content

Fix master warnings

Chris Cantwell requested to merge ccantwel/nektar:fix/master-warnings into master

Issue/feature addressed

A number of compiler warnings and performance test failures have made it into master.

Proposed solution

  • Update the performance test to account for an improvement in performance.
  • Address the compiler warnings

Implementation

The v_GetPressure function appears to be a no-op and is unused, but overrides the version provided by EquationSystem using different parameters. This has been removed.

Tests

Suggested reviewers

@CFD-Xing, @gaoak (since introduced the ReviewSolution solver)

Notes

Checklist

  • Functions and classes, or changes to them, are documented.
  • User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Chris Cantwell

Merge request reports