Skip to content

Fix: QuadExp::v_ComputeTraceNormal

BOYANG XIA requested to merge xby2233/nektar:fix/QuadExp_ComputeTraceNormal into master

Issue/feature addressed

A hotfix in QuadExp::v_ComputeTraceNormal to allow variable polynomial order in different directions, making its design consistent with other Expansions (Tri, Hex, Tet, etc)

Proposed solution

Just as what TriExp does, we should callGetTraceBasisKey to determine the correct space of trace normals.

Implementation

A more detailed description of the changes. Please include any details necessary for reviewers to understand your work, and point out particular points would like them to pay particular attention to.

Tests

Add a new AdevctWeakDG test case with a deformed quad mesh. The error is reasonable.

Suggested reviewers

Please suggest any people who would be appropriate to review your code.

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing

Merge request reports