Skip to content

Move solver info loading form NekSys (and its derived classes) to the callers

BOYANG XIA requested to merge xby2233/nektar:feature/SetLinSolverInfo into master

Issue/feature addressed

A NekSys object should focus on solving system based on the given infos (via NekSysKey). It should not load parameter from sessions, instead, the caller should be responsible for loading the parameter, setting the key and pass it to NekSys constructor.

Proposed solution

Move solver info loading from NekSys (and its derived classese) to the callers.


The callers includes GlobalLinSysIterativeFull GlobalLinSysIterativeStaticCond and CFSImplicit. Please notify me if there are other classes that should load info and set keys.


Suggested reviewers

Please suggest any people who would be appropriate to review your code.


Please add any other information that could be useful for reviewers.


  • [ ] Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • [ ] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing

Merge request reports