Some further tidy-up in linear solver and complete second Frechet derivative implementation
Issue/feature addressed
- This MR complete the implementation of second-order Frechet derivate for the JFNK solver of the compressible flow solver
- Use (consistently) minimum tolerance of 1.0E-16 in linear solve.
- Use
JacobiFreeEps = sqrt(NekConstants::kNekMachineEpsilon)
for consistency with publication - Rename
blas.cpp
asBlas.cpp
- Remove unused argument
const NekDouble factor
fromNekSys.h
class and subclasses - Move member variables specific to GMRES from
NekLinSysIter.h
toNekLinSysIterGMRES.h
andNekLinSysIterGMRESLoc.h
- Output both
Res/Res0
andRes/DtRHS
in Newton solver - Use member variable
m_converged
inConvergenceCheck
Proposed solution
Implementation
Tests
Suggested reviewers
Please suggest any people who would be appropriate to review your code.
Notes
Please add any other information that could be useful for reviewers.
Checklist
-
Functions and classes, or changes to them, are documented. [ ] User guide/documentation is updated.-
Changelog is updated. -
Suitable tests added for new functionality. -
Contributed code is correctly formatted. (See the contributing guidelines). [ ] License added to any new files.-
No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing