Skip to content
Snippets Groups Projects

Add CUDA backend implementation for AddTraceIntegral

Issue/feature addressed

The AddTraceIntegral operator was re-factored as general implementation AddTraceIntegralImpl.hpp. For the CUDA backend, this introduces repeated device/host and host/device copies. The same problem will occur with a Kokkos-CUDA backend.

Proposed solution

  • Full implement the locTraceToTraceMap in AddTraceIntegralSerialStdMat.hpp
  • Add a specialized CUDA backend AddTraceIntegralCUDASumFac.cuh and a specialized Kokkos backend AddTraceIntegralKokkosStdMat.hpp.

Implementation

Tests

  • The existing CUDA test is used to test the proposed new implementation
  • The existing Kokkos test is now disable as a Kokkos IProductWRTBase operator backend is not yet implemented

Suggested reviewers

Please suggest any people who would be appropriate to review your code.

Notes

Please add any other information that could be useful for reviewers.

Checklist

  • Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • [ ] Changelog is updated.
  • Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing

Merge request reports

Merge request pipeline #7485 passed with warnings

Merge request pipeline passed with warnings for d8420fb6

Approved by

Merged by Chris CantwellChris Cantwell 7 months ago (Jul 18, 2024 4:04pm UTC)

Merge details

  • Changes merged into feature/redesign with 00bf35d0 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jacques Xing changed the description

    changed the description

  • Jacques Xing added 6 commits

    added 6 commits

    Compare with previous version

  • Author Maintainer

    @ccantwel Ready to be merged, compiled with Serial, AVX, CUDA, Kokkos-Serial, Kokkos-CUDA.

  • Jacques Xing added 3 commits

    added 3 commits

    • 6c44b03c...b57a0c4e - 2 commits from branch nektar:feature/redesign
    • a47befda - Merge branch 'feature/redesign' into 'feature/redesign/addtraceintegral-cuda'

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading