Activate SYCL warning on GitLab CI
requested to merge CFD-Xing/nektar:feature/redesign-activate-sylc-kokkos-warning into feature/redesign
Issue/feature addressed
Activate SYCL warnings on GitLab CI
Proposed solution
Add following jobs to the CI:
debian-bookworm-full-icpx-warnings:
<<: *compiler-warning-template
needs: ["debian-bookworm-full-icpx-build-and-test"]
ubuntu-jammy-full--icpx-warnings:
<<: *compiler-warning-template
needs: ["ubuntu-jammy-full-icpx-build-and-test"]
Implementation
- Turn-off Wtautological-constant-compare)
- Solve unused variable warnings
Tests
Suggested reviewers
Notes
Due to a macro from an external library, TransfiniteSurface.cpp
causes a Wunused-variable
warning. The proposed solution is to disable this warning for this specific compilation unit.
#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-variable"
#endif
#include "TransfiniteSurface.h"
...
IMPLEMENT_STANDARD_RTTIEXT(Geom_TransfiniteCurve, Geom_BoundedCurve)
IMPLEMENT_STANDARD_RTTIEXT(Geom_TransfiniteSurface, Geom_BoundedSurface)
#if defined(__clang__)
#pragma clang diagnostic pop
#endif
Checklist
-
Functions and classes, or changes to them, are documented. [ ] User guide/documentation is updated.[ ] Changelog is updated.[ ] Suitable tests added for new functionality.[ ] Contributed code is correctly formatted. (See the contributing guidelines).[ ] License added to any new files.-
No extraneous files have been added (e.g. compiler output or test data files).
Edited by Jacques Xing