Draft: Activate SYCL warning on GitLab CI

Issue/feature addressed

Activate SYCL warnings on GitLab CI

Proposed solution

Add following jobs to the CI:

debian-bookworm-full-icpx-warnings:
  <<: *compiler-warning-template
  needs: ["debian-bookworm-full-icpx-build-and-test"]

ubuntu-jammy-full--icpx-warnings:
  <<: *compiler-warning-template
  needs: ["ubuntu-jammy-full-icpx-build-and-test"]

Implementation

• Turn-off Wtautological-constant-compare)
• Solve unused variable warnings

Tests

Suggested reviewers

Notes

Due to a macro from an external library, TransfiniteSurface.cpp causes a Wunused-variable warning. The proposed solution is to disable this warning for this specific compilation unit.

#if defined(__clang__)
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-variable"
#endif

#include "TransfiniteSurface.h"

...

IMPLEMENT_STANDARD_RTTIEXT(Geom_TransfiniteCurve, Geom_BoundedCurve)
IMPLEMENT_STANDARD_RTTIEXT(Geom_TransfiniteSurface, Geom_BoundedSurface)

#if defined(__clang__)
#pragma clang diagnostic pop
#endif

Checklist

• Functions and classes, or changes to them, are documented.
• [ ] User guide/documentation is updated.
• [ ] Changelog is updated.
• [ ] Suitable tests added for new functionality.
• [ ] Contributed code is correctly formatted. (See the contributing guidelines).
• [ ] License added to any new files.
• No extraneous files have been added (e.g. compiler output or test data files).

added mergeredesign label

assigned to @ccantwel

changed title from Feature/redesign activate sylc kokkos warning to Feature/redesign activate SYCL kokkos warning

added 1 commit

• 921cefdb - Fix GitLab YML file

Compare with previous version

changed title from Feature/redesign activate SYCL kokkos warning to Activate SYCL warning on GitLab CI

added 1 commit

• 28ba6825 - CLANG -> Clang

Compare with previous version

added 1 commit

• 4961b105 - Use IntelLLVM instead of Clang in warning check

Compare with previous version

added 1 commit

• 870877a7 - Revert accidental change

Compare with previous version

marked the checklist item Functions and classes, or changes to them, are documented. as completed

marked the checklist item No extraneous files have been added (e.g. compiler output or test data files). as completed

changed the description

added 1 commit

• 53470ab2 - Try turning-off Wunused-variable error for TransfiniteSurface.cpp

Compare with previous version

added 47 commits

• 53470ab2...5d8affa4 - 46 commits from branch nektar:feature/redesign
• ad987c53 - Merge remote-tracking branch 'upstream/feature/redesign' into...

Compare with previous version

added 1 commit

• 90824645 - Update pragma

Compare with previous version

changed the description

added 1 commit

• 0f8c2fcd - Update NektarCommon.cmake

Compare with previous version

added 8 commits

• 0f8c2fcd...28b9d861 - 6 commits from branch nektar:feature/redesign
• 7a01b298 - Merge remote-tracking branch 'upstream/feature/redesign' into...
• 435f88e8 - Merge remote-tracking branch...

Compare with previous version

marked this merge request as draft