Tidy/variable names

this stores the name of a variable held by an ExpList or a derived class in the ExpList itself instead of the session reader.

Reassigned to @ccantwel

Milestone changed to v4.3.0

buildbot is all green

@lackhove: Spencer, Dave and I discussed this last week and thought that changing the

Array<OneD, ExpListSharedPtr> m_fields;

to be instead a map, mapping variable name to the ExpList

map<string, ExpListSharedPtr> m_fields;

might be a reasonable solution for you in the short-term and still align with our long-term plans for ExpList?

@ccantwel: that would work for being able to access a fields name from the filters, but require changing every solver that accesses m_fields by index.

If this MR collides with your plans for ExpList i would suggest storing the variable names in a separate member of EquationSystem, e.g. m_fieldNames. The names of auxiliary fields could be just appended to m_fieldNames. The disadvantage of this approach is that EquationSystem and its subclasses would need to make sure m_fieldNames always has at least as many entries as m_fields, but at least this would not require us to modify ExpList.

Milestone changed to v4.4.0

@lackhove @ccantwel @dmoxey @ssherw Hi guys, should we complete this and merge it?

mentioned in merge request !730 (closed)

changed milestone to %v5.0.0

@lackhove Is this MR now beyond its sell by date? I know we have discussed this in the past but we did not want to attach variable names to the ExpList.

@ssherw We didnt really make a decision whether we want to merge this or not. Anyway, its superseded by !730 (closed), so im closing this one

closed