Extend some meshing modules to 2D

This MR extends the functionality of NekMesh in 2D:

• The cyl module now works in 2D. The cylinder center can now be passed as a parameter, instead of always being at the origin.
• The boundary layer module is extended to Quads.
• A new module was created that generates curved edge information in 2D based on a prescribed function y=f(x).

Milestone changed to v4.4.0

@mt4313, @dmoxey: Could you both have a look over this branch since it touches NekMesh?

@ccantwel @dmoxey @d.serson. The code itself looks fine to me. The major change that will affect my work is the change to the BL module but it looks like the 3D code has just been moved into a separate functions (logically). Providing it passes buildbot that shouldn't be an issue, I think there is a test for prismatic splitting in there.

Just a few points.

Could we get a test for the quad splitting? On this note Nekmesh probably needs a more complete set of tests for all the modules.

A few modules have been added which inherit from another process module. That's not really the norm for NekMesh, all the modules inherit from the process module base class (as far as Im aware). I can see why this is done, to remove code duplication. Dave can comment on whether that is okay or will break something, just thought I'd point it out.

@d.serson: Could you add a test for the quad splitting? We will leave adding further tests for the existing modules to another time.

@mt4313: I have no objections to inheriting from other processing modules. Indeed this is only a programming consideration and helps avoid code duplication and the introduction of bugs. From the NekMesh usage perspective, each is still a separate module in its own right.

Added 1 commit:

• 1fd171c9 - Add test for quad bl splitting

@ccantwel : Ok. I included a test for the quad splitting.

@d.serson: Thanks, just running through buildbot.

@dmoxey: Any further comments?

The code and tests look fine to me -- good to have some 2D boundary layer capabilities in there. It would be good if we could perhaps document the ProcessCurve::v_GenerateEdgeNodes function, in particular an overview of how the optimisation procedure for future reference.

Added 1 commit:

• aa5fba02 - Add documentation to ProcessCurve::v_GenerateEdgeNodes

Great, thanks!

Status changed to merged

mentioned in commit 01538f19