Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
Nektar
Nektar
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 88
    • Issues 88
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 52
    • Merge Requests 52
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge Requests
  • !759

Merged
Opened Mar 29, 2017 by Kilian Lackhove@lackhoveMaintainer

Tidy: Move EquationSystem::EvaluateFunction and Forcing::EvaluateFunction into separate class

  • Overview 14
  • Commits 19
  • Changes 28

this MR tries to unify the two EvaluateFunction() implementations in Forcing and EquationSystem by moving them into a separate SessionFunction class which supports proper caching of the evaluated fields (has to be enabled in the contructor). My earlier caching implementation was a bit hacky and cached everything read from files (including i.e. InitialConditions). This one uses caching only when requested.

The Mappings library still has its own EvaluateFunction Implementation, but while the dependency graph would allow moving the SessionFunction to GlobalMappings, i dont think it makes sense having it there and prefer leaving it the way it is.

Assignee
Assign to
Reviewer
Request review from
v5.0.0
Milestone
v5.0.0 (Past due)
Assign milestone
Time tracking
Reference: nektar/nektar!759
Source branch: tidy/SessionFunction