Skip to content
Snippets Groups Projects

Fix HomogeneousPlane module after changes in MeshGraph

Merged Fix HomogeneousPlane module after changes in MeshGraph
fix/FC-HomogeneousPlane into master
Merged Douglas Serson requested to merge fix/FC-HomogeneousPlane into master

This fixes an issue in ProcessHomogeneousPlane caused by the recent changes to MeshGraph, since now the SessionReader is not initialised automatically when it is created.

I am not sure if it is ok to call InitSession directly, but since we do not need to read the geometry again this seemed like a reasonable thing to do here.

Merge request reports

Merged by Dave MoxeyDave Moxey 7 years ago (Jan 25, 2018 3:48pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dave Moxey
    Dave Moxey @dmoxey ·
    Owner

    Thanks for this. Calling InitSession is fine in this case, it would usually be done by MeshGraph::Read but if you're explicitly creating the reader then it doesn't matter. I see buildbot is running so I'll merge this in the morning.

  • Dave Moxey
    Dave Moxey @dmoxey ·
    Owner

    Looks like buildbot is failing but for a single test unrelated to this branch, so I'll go ahead and merge this now. (The failures might have something to do with the feature/scotch-multilevel branch I ran previously on the buildbots.)

  • Dave Moxey merged

    merged

  • Dave Moxey mentioned in commit 0599aaad

    mentioned in commit 0599aaad

Please register or sign in to reply