Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • Nektar Nektar
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 90
    • Issues 90
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Nektar
  • NektarNektar
  • Merge requests
  • !1436

Fix a shadowed loop counter variable in CardiacEP benchmark filter.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jacques Xing requested to merge CFD-Xing/nektar:fix/CardiacEPSolver-v_Finalise-error into master Nov 14, 2022
  • Overview 2
  • Commits 3
  • Pipelines 3
  • Changes 2

Issue/feature addressed

I noticed a potential typo in the v_Finalise function of solvers/CardiacEPSolver/Filters/FilterBenchmark.cpp

Proposed solution

The propose solution is to fix the indexing of the outer for loop.

Checklist

  • [ ] Functions and classes, or changes to them, are documented.
  • [ ] User guide/documentation is updated.
  • Changelog is updated.
  • [ ] Suitable tests added for new functionality.
  • Contributed code is correctly formatted. (See the contributing guidelines).
  • [ ] License added to any new files.
  • No extraneous files have been added (e.g. compiler output or test data files).

Warning

On the 19.07 the code formatting (code style) was standardised using clang-format, over the whole Nektar++ code. This means changes in your branch will conflict with formatting changes on the master branch. To resolve these conflicts , see #295

Edited Nov 15, 2022 by Chris Cantwell
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/CardiacEPSolver-v_Finalise-error